Change MultiIndex repr (labels -> codes) #24731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24731 +/- ##
===========================================
- Coverage 92.39% 43.07% -49.33%
===========================================
Files 166 166
Lines 52358 52358
===========================================
- Hits 48374 22551 -25823
- Misses 3984 29807 +25823
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24731 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 166 166
Lines 52358 52358
=======================================
Hits 48374 48374
Misses 3984 3984
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
MultiIndex._format_attrs
branch
from
88fb789 to
7a8d8b2
Compare
gfyoung
added
Output-Formatting
|
thanks @topper-123 |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #22511 (comment), the repr for MultiIndex ATM uses
labels, even though the parameter/attribute has been changed tocodes.This PR changes the repr, so it uses
codes.Fot the record I think we should either decide to adapt #22511 soon, or soon come up with an consensus about an alternative repr to be implemented. The current MultiIndex repr is really, really (really!) bad for large indexes and needs to be be changed.